Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUBLAS] Remove deprecated CUBLAS_TENSOR_OP_MATH flag #8130

Merged
merged 1 commit into from
May 26, 2021

Conversation

tkonolige
Copy link
Contributor

This flag is causes CUBLAS to use tensor cores on all operations. With f32 or f64 operations, this leads to loss of accuracy.

#7995

Supersedes #8108.
@areusch @comaniac

@comaniac
Copy link
Contributor

How about we keep the API but just use CUBLAS_DEFAULT_MATH? It preserves the interface of leveraging other math flags in the future. Specifically, CUBLAS_TF32_TENSOR_OP_MATH might be used when supporting TF32.

This flag is causes CUBLAS to use tensore cores on all operations. With
f32 or f64 operations, this leads to loss of accuracy.
@tkonolige tkonolige force-pushed the remove_cublas_tensorecore_flag branch from a74de41 to 4b93009 Compare May 25, 2021 23:19
@tqchen tqchen merged commit 31e21a2 into apache:main May 26, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
This flag is causes CUBLAS to use tensore cores on all operations. With
f32 or f64 operations, this leads to loss of accuracy.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
This flag is causes CUBLAS to use tensore cores on all operations. With
f32 or f64 operations, this leads to loss of accuracy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants